Skip to content

Don't ever warn about #[used] items being dead code. #41637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2017
Merged

Don't ever warn about #[used] items being dead code. #41637

merged 1 commit into from
Apr 30, 2017

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Apr 29, 2017

Fixes #41628 by whitelisting #[used] items in rustc::middle::dead.

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov
Copy link
Contributor

I bet someone recently read the @japaric's blog post :)
@bors r+

@bors
Copy link
Collaborator

bors commented Apr 29, 2017

📌 Commit c054b2a has been approved by petrochenkov

@eddyb
Copy link
Member Author

eddyb commented Apr 29, 2017

@petrochenkov Close, but, more like "@whitequark poked me on IRC".

@frewsxcv frewsxcv mentioned this pull request Apr 29, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 30, 2017
@frewsxcv
Rollup merge of rust-lang#41637 - eddyb:used-not-dead, r=petrochenkov
b7a6ad4 
Don't ever warn about #[used] items being dead code.

Fixes rust-lang#41628 by whitelisting `#[used]` items in `rustc::middle::dead`.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 30, 2017
@frewsxcv
Rollup merge of rust-lang#41637 - eddyb:used-not-dead, r=petrochenkov
43cb7c4 
Don't ever warn about #[used] items being dead code.

Fixes rust-lang#41628 by whitelisting `#[used]` items in `rustc::middle::dead`.
@frewsxcv frewsxcv mentioned this pull request Apr 30, 2017
Merged
bors added a commit that referenced this pull request Apr 30, 2017
@bors
Auto merge of #41643 - frewsxcv:rollup, r=frewsxcv
78f6318 
Rollup of 6 pull requests

- Successful merges: #41449, #41509, #41608, #41613, #41636, #41637
- Failed merges:
@bors bors merged commit c054b2a into rust-lang:master Apr 30, 2017
@eddyb eddyb deleted the used-not-dead branch April 30, 2017 07:56
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eddyb @rust-highfive @petrochenkov @bors @arielb1